Update to be compliant with kde license options
ClosedPublic
Actions

Authored by rizzitello on Jun 4 2017, 6:56 PM.

Details

Reviewers

laysrodrigues
tcanabrava
patrickelectric

Commits

R232:ed684c99346f: LICENSE -> COPYING.TXT
R232:d1f0849e7d4f: Update license to program guideline for kde license
R232:3151e16f871c: Update to be compliant with kde license options
R232:4f78755d7c33: Add license to the test client folder

Summary

Update license to program guideline for kde license

Diff Detail

Repository

R232 AtCore

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

rizzitello created this revision.Jun 4 2017, 6:56 PM

rizzitello added reviewers: laysrodrigues, tcanabrava, patrickelectric.Jun 4 2017, 6:56 PM

rizzitello added a subscriber: Atelier: AtCore.

Update to be compliant with kde license options
Update license to program guideline for kde license
LICENSE -> COPYING.TXT

Add a COPYING.txt file inside test client with the license of it.

This revision now requires changes to proceed.Jun 5 2017, 12:14 AM

Add license to the test client folder

laysrodrigues accepted this revision.Jun 5 2017, 8:42 PM

This revision is now accepted and ready to land.Jun 5 2017, 8:42 PM

Why we are moving to lgpl if it prevent someone to change the code to use it ?

I think that sith added LGPL because he followed this KDE Guideline: https://community.kde.org/Policies/Licensing_Policy
Where all KDE Libraries must be LGPL, but that is related with this KDE Products: kdelibs, kdepimlibs, kde-runtime and KDE Frameworks. And we aren't any of that.
So I think that we can keep everything GPL2.

Looks fine to me.

patrickelectric accepted this revision.Jun 7 2017, 11:49 PM

Closed by commit R232:3151e16f871c: Update to be compliant with kde license options (authored by rizzitello). · Explain WhyJun 8 2017, 12:29 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/atcore.h (24 lines)
M			src/atcore.cpp (22 lines)
M			src/gcodecommands.h (20 lines)
M			src/gcodecommands.cpp (20 lines)
M			src/ifirmware.h (22 lines)
M			src/ifirmware.cpp (22 lines)
M			src/plugins/aprinterplugin.h (20 lines)
M			src/plugins/aprinterplugin.cpp (22 lines)
M			src/plugins/grblplugin.h (20 lines)
M			src/plugins/grblplugin.cpp (22 lines)
M			src/plugins/marlinplugin.h (20 lines)
M			src/plugins/marlinplugin.cpp (22 lines)
M			src/plugins/repetierplugin.h (20 lines)
M			src/plugins/repetierplugin.cpp (22 lines)
M			src/plugins/sprinterplugin.h (20 lines)
M			src/plugins/sprinterplugin.cpp (22 lines)
M			src/plugins/teacupplugin.h (20 lines)
M			src/plugins/teacupplugin.cpp (22 lines)
M			src/printthread.h (26 lines)
M			src/printthread.cpp (22 lines)
M			src/seriallayer.h (22 lines)
M			src/seriallayer.cpp (22 lines)
M			src/temperature.h (22 lines)
M			src/temperature.cpp (24 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	15138	835e120		Jun 4 2017, 6:56 PM	★	★
Diff 2	15140	3964b9f	- Update to be compliant with kde license options	Jun 4 2017, 7:16 PM	★	★
Diff 3	15185	3964b9f	- Add license to the test client folder	Jun 5 2017, 8:08 PM	★	★
Diff 4	15267	3964b9f	R232:3151e16f871c1025841778f3e501e71210182e50	Jun 4 2017, 7:15 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
4f78755d7c33	05aec7720466	ed684c99346f	Chris Rizzitello	Add license to the test client folder	Jun 5 2017, 8:06 PM
ed684c99346f	f5239ae76415	d1f0849e7d4f	Chris Rizzitello	LICENSE -> COPYING.TXT (Show More…)	Jun 4 2017, 6:53 PM
d1f0849e7d4f	795bfe8fd416	3151e16f871c	Chris Rizzitello	Update license to program guideline for kde license (Show More…)	Jun 4 2017, 6:52 PM
3151e16f871c	ec09e19b9d82	3964b9f8418a	Chris Rizzitello	Update to be compliant with kde license options (Show More…)	Jun 4 2017, 6:45 PM

Update to be compliant with kde license optionsClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 15267

src/atcore.h

src/atcore.cpp

src/gcodecommands.h

src/gcodecommands.cpp

src/ifirmware.h

src/ifirmware.cpp

src/plugins/aprinterplugin.h

src/plugins/aprinterplugin.cpp

src/plugins/grblplugin.h

src/plugins/grblplugin.cpp

src/plugins/marlinplugin.h

src/plugins/marlinplugin.cpp

src/plugins/repetierplugin.h

src/plugins/repetierplugin.cpp

src/plugins/sprinterplugin.h

src/plugins/sprinterplugin.cpp

src/plugins/teacupplugin.h

src/plugins/teacupplugin.cpp

src/printthread.h

src/printthread.cpp

src/seriallayer.h

src/seriallayer.cpp

src/temperature.h

src/temperature.cpp

Update to be compliant with kde license options
ClosedPublic
Actions

Revision Contents
Changeset List