use kactivities to track the most used modules (kcmshell will need to as well)
and present them in the start page as 5 big icons
Details
- Reviewers
- None
- Group Reviewers
Plasma VDG - Commits
- R124:1018b86e48db: prototype of kactivity-based most used modules entries
empty kactivities db, show default set, after some usage, the most used modules come
on top
Diff Detail
- Repository
- R124 System Settings
- Branch
- mart/mostUsedModules
- Lint
No Linters Available - Unit
No Unit Test Coverage
I would like to suggest making the system settings icon 512 and the row of 5 icons 256. Can we also consider making the font for it 10 pt?
the font is whatever the configured system font is used, so i wouldn't change it, i can make "frequently used" an header component so it would be a bit bigger
the icon sizes we have named sizes only up to 128, wouldn't go much over than that, i can try tough
core/ModuleView.cpp | ||
---|---|---|
349 ↗ | (On Diff #15055) | not "kcm:/" ? |
sidebar/SidebarMode.cpp | ||
163 | just desktopName = QSortFilterProxyModel::data(index). | |
175 | don't you only need to do this when you create new MenuItem? | |
133 ↗ | (On Diff #15055) | Can I propose an alternative: At the moment you have QSortFilterProxy -> (ResultModel or DefaultModel) It might be neater to have QSortFilterProxy -> KConcatanateRowsProxyModel (ResultModel and DefaultModel) this means it'll start showing recently used as soon as you open 1 module and you don't need to have any logic code here. |
core/ModuleView.cpp | ||
---|---|---|
349 ↗ | (On Diff #15055) | i seen that kicker does application:desktopfile.desktop so i did the same, but is the same in the end |
sidebar/SidebarMode.cpp | ||
163 | I need to remove the kcm: part | |
133 ↗ | (On Diff #15055) | I can see a problem with this approach: if i open a module from the default list, i would then have a duplicate in the list, unless i scan the model of defaults and remove manually all the duplicates, which may become a bit complex. |
Make sure you test with --reverse too
sidebar/SidebarMode.cpp | ||
---|---|---|
163 | Right, but I meant don't call sourceModel()->data(mapToSource....) when you can just call the superclasses data method. | |
sidebar/package/contents/ui/IntroIcon.qml | ||
32 ↗ | (On Diff #15055) | |
sidebar/package/contents/ui/introPage.qml | ||
70 ↗ | (On Diff #15055) | Math.round() |
82 ↗ | (On Diff #15055) | keyboard nav? |