Follow-up patch for D4665 (bug #379433).
ClosedPublic

Authored by bevendorff on May 29 2017, 9:42 PM.

Details

Summary

I removed the two lines which auto-selected the project when there was only one entry in the project model. I'm pretty sure there was a reason why I
added those lines, but I don't recall which. Maybe other stuff has changed which has made these lines obsolete. At least it seems to work perfectly
without now. Please test.

Diff Detail

Repository
R33 KDevPlatform
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bevendorff created this revision.May 29 2017, 9:42 PM
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptMay 29 2017, 9:42 PM
brauch accepted this revision.May 29 2017, 10:24 PM
brauch added a subscriber: brauch.

Looks good to me, thanks. Should I push it or do you have commit access?

This revision is now accepted and ready to land.May 29 2017, 10:24 PM

I don't, so you have to push. But please test if you find any regressions first. I'm really not sure anymore what those lines were for. I suppose it was some workaround for when no project was selected and stuff wasn't saved properly.

Any progress?

brauch added a comment.Jun 3 2017, 1:38 PM

Sorry. I clicked around a bit with just one project open and it seems fine, I'll submit it to master, then we have enough time to catch issues. Thanks!

This revision was automatically updated to reflect the committed changes.