bevendorff (Janek Bevendorff)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Oct 17 2016, 6:26 PM (56 w, 6 d)
Availability
Available

Recent Activity

Jun 3 2017

bevendorff added a comment to D6019: Follow-up patch for D4665 (bug #379433)..

Any progress?

Jun 3 2017, 9:29 AM

May 29 2017

bevendorff added a comment to D6019: Follow-up patch for D4665 (bug #379433)..

I don't, so you have to push. But please test if you find any regressions first. I'm really not sure anymore what those lines were for. I suppose it was some workaround for when no project was selected and stuff wasn't saved properly.

May 29 2017, 10:30 PM
bevendorff added a dependency for D6019: Follow-up patch for D4665 (bug #379433).: D4665: Fix project tree state not being saved.
May 29 2017, 9:46 PM
bevendorff added a dependent revision for D4665: Fix project tree state not being saved: D6019: Follow-up patch for D4665 (bug #379433)..
May 29 2017, 9:46 PM
bevendorff created D6019: Follow-up patch for D4665 (bug #379433)..
May 29 2017, 9:42 PM

Feb 21 2017

bevendorff added a comment to D4665: Fix project tree state not being saved.

Does Phabricator not preserve the author's email? Use kde AT jbev dot net

Feb 21 2017, 9:34 PM

Feb 20 2017

bevendorff added inline comments to D4665: Fix project tree state not being saved.
Feb 20 2017, 11:09 PM
bevendorff updated the diff for D4665: Fix project tree state not being saved.
  • Rename getSelectedProjects() to selectedProjects()
Feb 20 2017, 11:08 PM
bevendorff added inline comments to D4665: Fix project tree state not being saved.
Feb 20 2017, 10:39 PM
bevendorff updated the diff for D4665: Fix project tree state not being saved.
  • Fix more code style issues, and also make the whole thing work when there is only one (unselected) project
Feb 20 2017, 4:28 PM
bevendorff added inline comments to D4665: Fix project tree state not being saved.
Feb 20 2017, 3:15 PM
bevendorff updated the diff for D4665: Fix project tree state not being saved.
  • Save previous selection, but only use it if nothing else is selected at the moment
Feb 20 2017, 2:22 PM
bevendorff updated the diff for D4665: Fix project tree state not being saved.
  • Don't query selected projects twice for no reason
Feb 20 2017, 12:49 PM
bevendorff updated the diff for D4665: Fix project tree state not being saved.
  • Add missing change in ProjectTreeView header
Feb 20 2017, 12:44 PM
bevendorff added a comment to D4665: Fix project tree state not being saved.

Thanks for the review.
I addressed the code style issues and also refactored the plugin a little to get rid of the ugly m_ctxProject altogether. There is no weird internal flip-flop pointer anymore which keeps track of a previous selection. Instead, selections are now queried on demand only.
I think the code flow should be much clearer with this, also in the existing parts. It also makes sure that everything works even when the treeview is manipulated by means other than a right-click menu.

Feb 20 2017, 12:41 PM
bevendorff updated the diff for D4665: Fix project tree state not being saved.
  • Fix code style issues and get rid of m_ctxProject pointer
Feb 20 2017, 12:37 PM

Feb 19 2017

bevendorff updated the diff for D4665: Fix project tree state not being saved.
  • Remove obsolete disconnect
Feb 19 2017, 4:09 PM
bevendorff updated the diff for D4665: Fix project tree state not being saved.
  • Use QPointer instead of relying on signals to reset project pointer
Feb 19 2017, 4:05 PM
bevendorff updated the diff for D4665: Fix project tree state not being saved.
  • Also restore treeview after re-configuring CMake/QMake project
Feb 19 2017, 3:42 PM
bevendorff updated the diff for D4665: Fix project tree state not being saved.
  • Check for nullptr (should never happen, but check nevertheless for compatibility with external plugins)
Feb 19 2017, 1:02 PM
bevendorff updated the diff for D4665: Fix project tree state not being saved.
  • Properly restore state for all projects after restarting KDevelop
Feb 19 2017, 3:16 AM
bevendorff created D4665: Fix project tree state not being saved.
Feb 19 2017, 2:29 AM

Oct 19 2016

bevendorff added a comment to D3105: Fix indenter issues for cstyle and cppstyle (bug #370715).

Where do you have trailing spaces?
No, I don't have commit access.

Oct 19 2016, 11:19 AM · KTextEditor

Oct 18 2016

bevendorff added a comment to D3105: Fix indenter issues for cstyle and cppstyle (bug #370715).

I find aligned assignment operators easier to read, but since you seem to prefer not to align them, I changed it (together with the other things you annotated).
And yes, the indentation unit tests pass. ;-)

Oct 18 2016, 11:55 PM · KTextEditor
bevendorff updated the diff for D3105: Fix indenter issues for cstyle and cppstyle (bug #370715).
  • Remove unnecessary modelines
  • Remove old code paths
  • Coding style
Oct 18 2016, 11:52 PM · KTextEditor
bevendorff abandoned D3104: Fix indenter issues for cstyle and cppstyle (DUPLICATE).

Ah, okay. Not very discoverable that feature. Had to search quite a bit.

Oct 18 2016, 9:15 PM · KTextEditor
bevendorff retitled D3104: Fix indenter issues for cstyle and cppstyle (DUPLICATE) from Fix indenter issues for cstyle and cppstyle to Fix indenter issues for cstyle and cppstyle (DUPLICATE).
Oct 18 2016, 8:46 PM · KTextEditor
bevendorff updated the diff for D3105: Fix indenter issues for cstyle and cppstyle (bug #370715).
  • Remove debug line
Oct 18 2016, 8:44 PM · KTextEditor
bevendorff added a comment to D3104: Fix indenter issues for cstyle and cppstyle (DUPLICATE).

Alright, seems to work. It created a new revision, though: https://phabricator.kde.org/D3105
I guess this one can be discarded then.

Oct 18 2016, 8:38 PM · KTextEditor
bevendorff retitled D3105: Fix indenter issues for cstyle and cppstyle (bug #370715) from Fix unindentation when writing opening braces with auto brackets enabled (bug #370715) to Fix indenter issues for cstyle and cppstyle (bug #370715).
Oct 18 2016, 8:37 PM · KTextEditor
bevendorff retitled D3105: Fix indenter issues for cstyle and cppstyle (bug #370715) from to Fix unindentation when writing opening braces with auto brackets enabled (bug #370715).
Oct 18 2016, 8:36 PM · KTextEditor
bevendorff added a comment to D3104: Fix indenter issues for cstyle and cppstyle (DUPLICATE).

Did you try arc from the command-line? See https://community.kde.org/Infrastructure/Phabricator#Posting_Patches.

Oct 18 2016, 8:33 PM · KTextEditor
bevendorff added a comment to D3104: Fix indenter issues for cstyle and cppstyle (DUPLICATE).

Hmm. Somehow Phabricator only accepts the first file. The patch contains changes in many files, though. How do I submit the full patch here?

Oct 18 2016, 8:29 PM · KTextEditor
bevendorff updated the diff for D3104: Fix indenter issues for cstyle and cppstyle (DUPLICATE).
Oct 18 2016, 8:28 PM · KTextEditor
bevendorff retitled D3104: Fix indenter issues for cstyle and cppstyle (DUPLICATE) from to Fix indenter issues for cstyle and cppstyle.
Oct 18 2016, 8:22 PM · KTextEditor