Differential D600

fsck routine to cleanup rid duplicates
ClosedPublic
Actions

Authored by knauss on Nov 27 2015, 4:02 PM.

Details

Reviewers
dvratil
Maniphest Tasks
T1110: merge kolab akonadi changes
Commits
R165:90e1ec2ed6e9: fsck routine to cleanup rid duplicates
Summary

notes from randa:

  • Turn inform into akDebug. return on exec fail of queries

I read this that i should change the akDebug to a inform.

Diff Detail

Repository
R165 Akonadi
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
knauss updated this revision to Diff 1396.Nov 27 2015, 4:02 PM
knauss retitled this revision from to fsck routine to cleanup rid duplicates.
knauss updated this object.
knauss edited the test plan for this revision. (Show Details)
knauss added a reviewer: dvratil.
knauss added a task: T1110: merge kolab akonadi changes .
dvratil added inline comments.Dec 5 2015, 6:48 PM
src/server/storagejanitor.cpp
531

You don't need to addColumns() for a DELETE query

535

Is this actually effective enough? I mean the chance that you will have an item in the collection that does not belong there based on mimetypes? I don't think that is even possible...

knauss updated this revision to Diff 2784.Mar 15 2016, 4:26 PM
knauss marked an inline comment as done.

Updates with Daniels comments.

Restricted Application added a project: KDE PIM. · View Herald TranscriptMar 15 2016, 4:26 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
knauss added a subscriber: cmollekopf.Mar 15 2016, 4:27 PM
knauss added inline comments.
src/server/storagejanitor.cpp
535

There you have to ask @cmollekopf what is the background for this.

cmollekopf added inline comments.Mar 15 2016, 4:42 PM
src/server/storagejanitor.cpp
535

This happened in the kolab resource (I think we created mails in groupware folders when synchronizing flags only and thus not recognizing the groupware type). The mimetype was the only safe assumption I could take, and that worked for the problem at hand. I recently witnessed a similar problem, but this time with the same mimeType, in which case there is no safe assumption to take (but perhaps we could just remove both and ensure the change is not replayed to the server, so the next sync would fix the problem).

dvratil accepted this revision.Mar 16 2016, 11:40 AM
dvratil edited edge metadata.
This revision is now accepted and ready to land.Mar 16 2016, 11:40 AM
Closed by commit R165:90e1ec2ed6e9: fsck routine to cleanup rid duplicates (authored by cmollekopf, committed by knauss). · Explain WhyMar 16 2016, 12:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 2797

View Options

src/server/storagejanitor.h

Loading...
View Options

src/server/storagejanitor.cpp

Loading...