These changes allow replying to any notifications that offer quick reply text fields

Authored by progwolff on May 27 2017, 8:12 PM.

Diff Detail

R224 KDE Connect
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
progwolff created this revision.May 27 2017, 8:12 PM
apol added a subscriber: apol.May 27 2017, 9:45 PM
apol added inline comments.

QString() to create an empty string.


Why do you need telepathy here? This looks like it belongs to the telephony plugin

31 ↗(On Diff #14897)

Rename the dialog? Maybe make generic?

progwolff updated this revision to Diff 14922.May 29 2017, 7:16 AM
progwolff updated this revision to Diff 14923.May 29 2017, 7:18 AM
  • remove unneccessary include
apol accepted this revision.May 29 2017, 9:44 AM

Looks good. I'd say it can be committed together with the Android side.

A nice addition to this would be to add a little mark on the notification in the plasmoid notifications list so that the reply can be triggered.

This revision is now accepted and ready to land.May 29 2017, 9:44 AM
This revision was automatically updated to reflect the committed changes.