These changes allow replying to any notifications that offer quick reply text fields
Details
Details
- Reviewers
apol - Group Reviewers
KDE Connect - Maniphest Tasks
- T4674: Reply to any notification (whatsapp, etc)
- Commits
- R224:53dfb34c1bf1: These changes allow replying to any notifications that offer quick reply text…
R224:4eeb32901425: These changes allow replying to any notifications that offer quick reply text…
Diff Detail
Diff Detail
- Repository
- R224 KDE Connect
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage
plugins/notifications/notification.cpp | ||
---|---|---|
147 | QString() to create an empty string. | |
plugins/notifications/notificationsdbusinterface.cpp | ||
37 | Why do you need telepathy here? This looks like it belongs to the telephony plugin | |
plugins/notifications/sendsmsdialog.h | ||
31 ↗ | (On Diff #14897) | Rename the dialog? Maybe make generic? |
Comment Actions
- Merge branch 'master' of https://github.com/KDE/kdeconnect-kde
- remove telepathy interface. rename reply dialog.
Comment Actions
Looks good. I'd say it can be committed together with the Android side.
A nice addition to this would be to add a little mark on the notification in the plasmoid notifications list so that the reply can be triggered.