Fix compilation of Python bindings
ClosedPublic
Actions

Authored by aacid on May 26 2017, 9:20 PM.

Details

Reviewers

Commits

R249:adca5fa181a0: Fix compilation of Python bindings

Summary

We only need to pass TRANSLATION_DOMAIN when compiling the C++ code since it's the only part that contains i18n() calls.

Reason: The klocalizedstring code fails to compile if that is defined (see how klocalizedstring.cpp undefines it)

Repository

R249 KI18n

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: Frameworks. · View Herald Transcript

I'll try to test and report back.

This revision is now accepted and ready to land.May 27 2017, 7:20 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			CMakeLists.txt (1 line)
M			src/CMakeLists.txt (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	14868	bb62780		May 26 2017, 9:20 PM	★	★
Diff 2	14877	ff0ef7a	R249:adca5fa181a04bb5c7d46e9934fbbe46671fd230	May 27 2017, 9:06 AM	★	★