Solve T6165 by checking temperature in a more generic way using regexpression. temperature checks no longer require any plugin
Details
Details
Test on various Firmwares: Must Set all values and have working heaters and thermistors
Repetier Working!
T:44.53 /180 B:45.08 /93 B@:255 @:255 Extruder Temperature [0] : 44 Extruder Target Temperature [0] : 180 Bed Temperature [0] : 45 Bed Target Temperature [0] : 93
Marlin <Unknown>
put results here
Teacup <unknown>
put results here
Diff Detail
Diff Detail
- Repository
- R232 AtCore
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| src/atcore.cpp | ||
|---|---|---|
| 259 | You can put everything here in temperature class and the plugin can use something like: plugin::extractTemp() {
core()->extractGenericTemperature()
}AtCore is supposed to perform only operations and not decode, this'll not work in binary protocols or other temperature/protocol type message. | |
| src/atcore.cpp | ||
|---|---|---|
| 259 | if were gonna do that we might as well just continue to use extractTemp from the plugins and just change that to work more like this Do we have any examples of these firmwares output (these binary ones your talking about) | |
| src/atcore.cpp | ||
|---|---|---|
| 259 | I am just saying that atcore isn't the place to add info extraction functions, this need to be inside plugins files or (less worst) in temperature class. If we gonna to start to put everything in atcore, just delete all plugins files, and that will be a big problem in future. | |
Comment Actions
- Remove Temperature Checks from all plugins
- Check temperature in a more generic way by using regexpression temperature checks no longer
- Better Regex after further work with lays