Differential D5890

Pass `--key-positions=*` to gperf instead of `-k *` because on Windows this symbol seems to have a special meaning.
ClosedPublic
Actions

Authored by arrowd on May 16 2017, 6:40 PM.

Details

Reviewers
bcooksley
Group Reviewers
Frameworks
Commits
R313:07a8a4e6985c: Pass `--key-positions=*` to gperf instead of `-k *` because on Windows this…
Summary

Pass --key-positions=* to gperf instead of -k * because on Windows this symbol seems to have a special meaning.

Test Plan

Successfully compiled with MSVC.

Diff Detail

Repository
R313 KHtml
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
arrowd created this revision.May 16 2017, 6:40 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMay 16 2017, 6:40 PM
This revision is now accepted and ready to land.May 18 2017, 9:59 AM
arrowd added a comment.May 18 2017, 11:16 AM
In D5890#110586, @bcooksley wrote:

This looks good to me. Would this also resolve https://build-sandbox.kde.org/view/Frameworks/job/Frameworks%20kcodecs%20kf5-qt5%20WindowsQt5.7/6/console ?

Invalid position value or range, use 1,2,3-255,'$' or '*'.

Yep, looks like it.

Closed by commit R313:07a8a4e6985c: Pass `--key-positions=*` to gperf instead of `-k *` because on Windows this… (authored by arrowd). · Explain WhyMay 18 2017, 11:17 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/CMakeLists.txt (2 lines)

Diff 14663

View Options

src/CMakeLists.txt

Loading...