Differential D586

Only set isDirty if something was changed
AbandonedPublic
Actions

Authored by knauss on Nov 24 2015, 5:19 PM.

Tags

Subscribers

None

Details

Reviewers

mlaurent
smartins
vkrause

Group Reviewers

Maniphest Tasks

T1102: merge kolab kcalcore changes

Commits

R172:4c9906e686b2: Only set isDirty if something was changed

Summary

Do not add field to dirtyField, only because a set function was called.

Diff Detail

Lint

No Linters Available

Unit

No Unit Test Coverage

knauss updated this revision to Diff 1371.Nov 24 2015, 5:19 PM

knauss retitled this revision from to Only set isDirty if something was changed.

knauss updated this object.

knauss edited the test plan for this revision. (Show Details)

knauss added reviewers: vkrause, mlaurent, smartins.

knauss added a task: T1102: merge kolab kcalcore changes.

knauss added a reviewer: KDE PIM.Nov 24 2015, 5:43 PM

knauss added a project: KDE PIM.

a couple of comments, looks good otherwise

src/incidence.cpp
400	Reorder for performance: if (d->mRecurrence && dirtyFields().contains(FieldDtStart))
src/recurrence.cpp
490	space after if
715	return nullptr;

This revision now requires changes to proceed.Nov 24 2015, 9:57 PM

Update with smartins comments

commited with 4c9906e686b293db50dc18f3cfcc0cde44e4665b

Revision Contents
Changeset List

			Path	Packages
M			autotests/CMakeLists.txt (1 line)
P			autotests/testevent.h (1 line) Copied to autotests/testincidence.h
M			autotests/testevent.cpp (23 lines)
P			autotests/testincidence.h (32 lines) Copied from autotests/testevent.h
A	M		autotests/testincidence.cpp (276 lines)
M			src/event.cpp (15 lines)
M			src/incidence.cpp (28 lines)
M			src/incidencebase.cpp (13 lines)
M			src/recurrence.h (12 lines)
M			src/recurrence.cpp (138 lines)
M			src/recurrencerule.cpp (4 lines)

Diff 1481

autotests/CMakeLists.txt

Loading...

autotests/testevent.h

Loading...

autotests/testevent.cpp

Loading...

autotests/testincidence.h

Loading...

autotests/testincidence.cpp

Loading...

src/event.cpp

Loading...

src/incidence.cpp

Loading...

src/incidencebase.cpp

Loading...

src/recurrence.h

Loading...

src/recurrence.cpp

Loading...

src/recurrencerule.cpp

Loading...