cmake: switch to the FindPoppler module from ECM

Authored by pino on May 14 2017, 6:15 AM.



Bump the ECM requirement to 5.19, which provides a better FindPoppler
than the local copy (which was itself copied from okular).
As result, we can search for Qt5 component specifically, and use the
Poppler::Qt5 target where needed, with no more manual include

Diff Detail

R37 Krita
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
pino created this revision.May 14 2017, 6:15 AM
pino added a comment.May 14 2017, 6:18 AM

This should be a no-brainer (I've done similar changes in other repositories) -- the reason why I'm send a review is because of the ECM bump (although ECM/Frameworks 5.19 was released on February 2016, so 15 months old already).

rempt accepted this revision.May 15 2017, 8:07 AM
rempt added a subscriber: rempt.

Yes, that's fine. I've checked our 3rdparty/ext_frameworks external project (which is used to build all deps on platforms other than standard Linux), and we use 5.24 at the moment. (Except for ki18n, which is broken on windows > 5.17...)

This revision is now accepted and ready to land.May 15 2017, 8:07 AM
This revision was automatically updated to reflect the committed changes.