Bump the ECM requirement to 5.19, which provides a better FindPoppler
than the local copy (which was itself copied from okular).
As result, we can search for Qt5 component specifically, and use the
Poppler::Qt5 target where needed, with no more manual include
directories.
Details
Details
- Reviewers
rempt - Group Reviewers
Krita - Commits
- R37:2368e22c7530: cmake: switch to the FindPoppler module from ECM
R37:1e69c41cec1e: cmake: switch to the FindPoppler module from ECM
Diff Detail
Diff Detail
- Repository
- R37 Krita
- Branch
- cmake-poppler
- Lint
No Linters Available - Unit
No Unit Test Coverage
Comment Actions
This should be a no-brainer (I've done similar changes in other repositories) -- the reason why I'm send a review is because of the ECM bump (although ECM/Frameworks 5.19 was released on February 2016, so 15 months old already).
Comment Actions
Yes, that's fine. I've checked our 3rdparty/ext_frameworks external project (which is used to build all deps on platforms other than standard Linux), and we use 5.24 at the moment. (Except for ki18n, which is broken on windows > 5.17...)