Use absolute imports in GDB scripts
ClosedPublic

Authored by rkapl on May 12 2017, 4:03 PM.

Details

Summary

Citing pep-0008:
"Implicit relative imports should never be used and have been removed in Python 3."

This fixes problems at least on Arch where gdb is compiled with python3.

Clone of https://github.com/KDE/kde-dev-scripts/pull/2. I was not sure about the reviewer, hope it's correct.

Diff Detail

Repository
R230 KDE Development Scripts
Lint
Lint Skipped
Unit
Unit Tests Skipped
rkapl created this revision.May 12 2017, 4:03 PM
rkapl edited the summary of this revision. (Show Details)May 12 2017, 4:10 PM
rkapl added a reviewer: KDE Applications.
ltoscano added a subscriber: ltoscano.

There is another proposal at D5660; if you can check it and agree on the cleanest one, it would simplify the review :)

scarpino accepted this revision.May 12 2017, 9:47 PM
scarpino added a subscriber: scarpino.

Looks good, I confirm this works too.

This revision is now accepted and ready to land.May 12 2017, 9:47 PM

@rkapl, I guess that you don't have commit access. Should I use your data (name, surname, email) from the github account?

@rkapl, I guess that you don't have commit access. Should I use your data (name, surname, email) from the github account?

Correct, I don't have commit access, I sent just this patch to KDE. You can use the github info, I am not sure what is visible there. Anyway it's Roman Kapl <code@rkapl.cz> or commit under your name.

This revision was automatically updated to reflect the committed changes.