must be reworked :D
Details
Details
- Reviewers
vkrause - Group Reviewers
KDE PIM - Maniphest Tasks
- T719: Refactor objecttreeparser
- Commits
- R94:f64b0bd7dbc5: bit hack to get multiple formateres for one type working.
Diff Detail
Diff Detail
- Repository
- R94 PIM: Message Library
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
So far i can run rendertests, it only fails for the external plugin test with ns-ktnef, because i havn't updated them and i changed the interface with the process function.
| messageviewer/src/interfaces/bodypartformatter.h | ||
|---|---|---|
| 53 | we need the MessagePart in Interface to have the process function with MessagePart as return value | |
| 71 | is used to descide if we have the interface or a propper messagepart. | |
| 76 | it is defined in viewer/bodyforamtter.cpp this is really not a way to go - but it is working... | |
| messageviewer/src/viewer/objecttreeparser.cpp | ||
| 343 | i cant't return sub.find(subtype), because than i have no end element, with i can test the end. | |
| 344 | can this break? if i return a empty iterator? | |
| 362 | need a better way to detect asIcon | |
| messageviewer/src/interfaces/bodypartformatter.h | ||
|---|---|---|
| 71 | Can't you use dynamic_cast for that? That would use the already existing type information rather than something string-based. To the very least, use an enum for this, not a string. | |