Differential D581

allow multiple Formatters for one type
AbandonedPublic
Actions

Authored by knauss on Nov 23 2015, 12:23 PM.

Details

Reviewers
vkrause
Group Reviewers
KDE PIM
Maniphest Tasks
T719: Refactor objecttreeparser

Diff Detail

Lint
No Linters Available
Unit
No Unit Test Coverage
knauss updated this revision to Diff 1349.Nov 23 2015, 12:23 PM
knauss retitled this revision from to allow multiple Formatters for one type.
knauss updated this object.
knauss edited the test plan for this revision. (Show Details)
knauss added a reviewer: vkrause.
knauss added a task: T719: Refactor objecttreeparser.
knauss added a reviewer: KDE PIM.Nov 23 2015, 12:28 PM
knauss added a project: KDE PIM.
knauss added a comment.Nov 23 2015, 12:32 PM

this diff only makes sense together with D582 - but is also a WIP

aka I'm not happy with both patches

messageviewer/src/viewer/bodypartformatter.cpp
181

this on the new

189

only move it back to the makro, becuse it was only splitted to make it easier to refactor.

202–226

use mulimap so we need now to use insert

messageviewer/src/viewer/bodypartformatterfactory.cpp
107

we don't want to delete the old formatters, only add the new one

messageviewer/src/viewer/bodypartformatterfactory.h
68

we need the iterator in otp to test all formatters

vkrause added inline comments.Nov 28 2015, 8:54 AM
messageviewer/src/viewer/bodypartformatterfactory.cpp
164–193

This method name is a bit misleading, the result has nothing to do with iterators. How about "subtypeRegistery(const char* type)"?

knauss updated this revision to Diff 1628.Dec 27 2015, 1:42 PM
knauss marked an inline comment as done.

Updates with volkers suggestions

Revision Contents
Changeset List

Diff 1628

View Options

messageviewer/src/viewer/bodypartformatter.cpp

Loading...
View Options

messageviewer/src/viewer/bodypartformatterfactory.h

Loading...
View Options

messageviewer/src/viewer/bodypartformatterfactory.cpp

Loading...
View Options

messageviewer/src/viewer/bodypartformatterfactory_p.h

Loading...