Differential D5801

Split XDGTest to allow testing both V5 and V6
AbandonedPublic
Actions

Authored by davidedmundson on May 10 2017, 9:18 PM.

Details

Reviewers
graesslin
Group Reviewers
Plasma
Commits
R127:078bf898a0ba: Split XDGTest to allow testing both V5 and V6
Summary

We want to test V6 using the exact same tests.

We already use the QtTest rows inside the XdgClient, using that also for
this separation gets quite complicated.

Test Plan

Current test still passes.

Diff Detail

Repository
R127 KWayland
Branch
davidedmundson/xdgv6
Lint
No Linters Available
Unit
No Unit Test Coverage
davidedmundson created this revision.May 10 2017, 9:18 PM
Restricted Application added projects: Plasma on Wayland, Frameworks. · View Herald TranscriptMay 10 2017, 9:18 PM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript
graesslin accepted this revision.May 11 2017, 5:10 AM
graesslin added a subscriber: graesslin.

Are you sure the API is so compatible that you can run it like that?

This revision is now accepted and ready to land.May 11 2017, 5:10 AM
davidedmundson added a comment.May 11 2017, 9:19 AM

I've made it compatible.

There will be some differences, especially for popup but we want that difference exposed in some hasBlahCapability() flag, so we can redirect the test as appropriate.

davidedmundson abandoned this revision.May 31 2017, 9:32 AM

I was hoping to put anything that affected v5 in a separate commits, with v6 separate, but that didn't really happen.

Will include with the other stuff.

Revision Contents
Changeset List

Diff 14379

View Options

autotests/client/CMakeLists.txt

Loading...
View Options

autotests/client/test_xdg_shell.cpp

Loading...
View Options

autotests/client/test_xdg_shell_v5.cpp

Loading...