this ensure two things:
- submenus have the main menu as transientParent
- the visualParent window() is used as transientParent, if exists
this partly fixes popup positioning in wayland, tough
the main taskbar menu is still mis positioned
Details
Details
- Reviewers
davidedmundson - Group Reviewers
Plasma Plasma on Wayland - Commits
- R242:680a8a9e2832: [WIP] workarounds for menu positioning
submenus ok, taskbar contextmenus only partially fixed
Diff Detail
Diff Detail
- Repository
- R242 Plasma Framework (Library)
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
looks sensible.
Is this only needed for a specific version of Qt? In either case can you check on the Qt 5.7 machine.
| src/declarativeimports/plasmacomponents/qmenu.cpp | ||
|---|---|---|
| 112 | there's a code path in open that says: if (m_visualParent) {
parentItem = qobject_cast<QQuickItem *>(m_visualParent.data());
} else {
parentItem = qobject_cast<QQuickItem *>(parent());
}does this not need doing for the latter branch? | |
| src/declarativeimports/plasmacomponents/qmenu.cpp | ||
|---|---|---|
| 315–320 | why not just also do the code at line 113 here? will be simpler code all round. | |
| src/declarativeimports/plasmacomponents/qmenu.cpp | ||
|---|---|---|
| 117 | we always do this in ::open() so why have this chunk? | |