recreate plasmashellsurf on exposed, destoy on hidden
ClosedPublic

Authored by mart on May 7 2017, 5:13 PM.

Details

Summary

every time the window gets shown the wayland surfaces
get created, when hidden, they get destroyed

showevent is too early for it as they aren't there yet,
use :Exposed instead, but only the first time when the surface
isn't there yet

Test Plan

popup applets always have correct blur in a wayland
session

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart created this revision.May 7 2017, 5:13 PM
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptMay 7 2017, 5:13 PM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript
davidedmundson added inline comments.
src/plasmaquick/dialog.cpp
1123–1142

we also get an expose on hide, but with a null region.

Can you add:

auto ee = static_cast<QExposeEvent*>(event);

+ if (ee->region().isNull()) {
+ return false;
+ }

mart updated this revision to Diff 14246.May 7 2017, 5:38 PM
  • check null region
mart updated this revision to Diff 14247.May 7 2017, 5:45 PM
  • don't return false
davidedmundson accepted this revision.May 12 2017, 2:48 PM

some code comments would be good.
you can copy update T6064

This revision is now accepted and ready to land.May 12 2017, 2:48 PM
mart updated this revision to Diff 14435.May 12 2017, 2:57 PM

comments

Restricted Application edited projects, added Plasma on Wayland; removed Plasma. · View Herald TranscriptMay 12 2017, 2:57 PM
This revision was automatically updated to reflect the committed changes.