Differential D5713

Fix quoting of preprocessor-definition.
ClosedPublic
Actions

Authored by adridg on May 5 2017, 11:48 AM.

Details

Reviewers
dfaure
bcooksley
Commits
R241:def270105286: Fix quoting of preprocessor-definition.
Summary

If the LIBEXECDIR contains spaces (as it does specifically on the CI
systems) then this needs one extra layer of quoting to protect it from the
shell.

Test Plan

Build on the CI systems

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
adridg created this revision.May 5 2017, 11:48 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptMay 5 2017, 11:48 AM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
bcooksley accepted this revision.May 5 2017, 11:55 AM

From a theoretical perspective this looks fine to me.

This revision is now accepted and ready to land.May 5 2017, 11:55 AM
Closed by commit R241:def270105286: Fix quoting of preprocessor-definition. (authored by adridg). · Explain WhyMay 5 2017, 3:27 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mautotests/CMakeLists.txt (2 lines)

Diff 14159

View Options

autotests/CMakeLists.txt

Loading...