First attempt to port remaining dbo* statements to qCDebug().
Needs ReviewPublic

Authored by ouwerkerk on May 2 2017, 6:19 PM.

Details

Reviewers
None
Group Reviewers
KDE Games
Summary

This attempt amounts to a search/replace of most dbo* statements.
It relies on the fact that qCDebug() supports a printf() style invocation/syntax since Qt 5.3.
This change partially resolves Phabricator/Maniphest issue T5980.

Test Plan

It compiles.

Diff Detail

Repository
R417 KSudoku
Branch
pretty-print-operator-overload
Lint
No Linters Available
Unit
No Unit Test Coverage
ouwerkerk created this revision.May 2 2017, 6:19 PM
Restricted Application added a reviewer: KDE Games. · View Herald TranscriptMay 2 2017, 6:19 PM
Restricted Application added a subscriber: KDE Games. · View Herald Transcript

This is mainly a first attempt to get the ball rolling. It kills off nearly all of the previously remaining dbo* statements with one fell swoop of Search & Replace.

So basically the scope of the patch are all the "non controversial" statements.

qC* adds a newline, so the final \n should be removed. But then, change required anyway, at least the statements without arguments could be modified to use the other format. As you prefer.

ouwerkerk updated this revision to Diff 14114.May 3 2017, 6:14 PM

Port pretty printing of board contents to qCDebug().

ouwerkerk updated this revision to Diff 14138.May 4 2017, 5:25 PM

Some clean up work to remove QtDebug include from sudokuboard.h

Move contents of SudokuBoard::prettyPrint/SudokuBoard::print to BoardContentsPrettyPrinter::print().