fix build against Android NDK (API Level 21 is required)
ClosedPublic
Actions

Authored by mgallien on Apr 27 2017, 7:32 PM.

Details

Reviewers

Group Reviewers

Android
Frameworks

Commits

Summary

fix build against Android NDK (API Level 21 is required)

Test Plan

Test compilation under linux and Android

Repository

R286 KFileMetaData

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: Frameworks. · View Herald Transcript

+1 LGTM.

Maybe you can specify on the commit message that attr/xattr.h isn't present on the Android NDK and add a comment on the ifdef wouldn't hurt either.

added a comment and also modify the commit message

Ping

This revision is now accepted and ready to land.May 8 2017, 10:43 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/xattr_p.h (9 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	13887	190e835		Apr 27 2017, 7:32 PM	★	★
Diff 2	13901	190e835	added a comment and also modify the commit message	Apr 28 2017, 5:06 AM	★	★
Diff 3	14306	8527206	R286:ecee5fc8e3cc7f5eafd3746dcd946c460268d5a3	May 8 2017, 7:00 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
c2dda25c200b	af30a9e0e7e5	190e8359937c	Matthieu Gallien	fix build against Android NDK (API Level 21 is required) (Show More…)	Apr 27 2017, 7:31 PM