Install Plasma Components 3 so they can be used

Authored by davidedmundson on Apr 26 2017, 3:37 PM.



PlasmaComponents 3 exists both as a theme for QQC2 but also to be used
directly like the current Plasma Components.

Currently they install into org.kde.plasma.components.3 which isn't a
valid path, also it doesn't include the qmldir, so you can't load it

This patch installs the files to a subdir of org.kde.plasma.components
then update the original root qmldir toload the QQC2 version if the
version matches.

Test Plan

Actually used them in a Plasmoid

Diff Detail

R242 Plasma Framework (Library)
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Apr 26 2017, 3:37 PM
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptApr 26 2017, 3:37 PM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript
mart requested changes to this revision.Apr 26 2017, 4:51 PM
mart added a subscriber: mart.
mart added inline comments.

components.3 is actually what is searched for by the import system when importing a versioned import (kirigami is doing this as well)

39 ↗(On Diff #13839)

the components.3 folder should have its own qmldir instead

This revision now requires changes to proceed.Apr 26 2017, 4:51 PM

Did not know about that little feature. That's much tidier.

Then the only thing that's wrong is that we don't install the qmldir file, which is what sent me on this wild chase this morning.
(interestingly my desktop did have that file, I guess it was installed in an earlier prototype that I had installed, probably the same for you too)

davidedmundson edited edge metadata.

Much simpler change

mart accepted this revision.Apr 27 2017, 9:29 AM

thanks, awesome now =)

This revision is now accepted and ready to land.Apr 27 2017, 9:29 AM
This revision was automatically updated to reflect the committed changes.