Create KAboutData object only after QApp instance, for working translations

Authored by kossebau on Apr 26 2017, 12:48 PM.



i18n() calls gettext, which only after some setlocale(LC_ALL, ""); starts
to look for env variables when deciding on the language catalog to use.
That call is done during QApp instance creation.

See also and

Discussion if that is supposed to be like that has to be continued,
but for now this change should keep KDevelop on the safe side.

Diff Detail

R32 KDevelop
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.Apr 26 2017, 12:48 PM
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptApr 26 2017, 12:48 PM

Target: 5.1


These two lines are supposed to go in as separate commit.

Full support for it from me of course :) just a minor question.


Is the comment still valid for QCommandLineParser? At least the comment should be updated.

kossebau added inline comments.Apr 26 2017, 8:55 PM

Good eyes, too good ;)
Saw that as well, but was to look at that next only, as I need to make myself properly familiar with commandline parsing first and want to get these two bug fixes in the patch here already in, while I wait for time & motivation to look closer at that one ;)

kfunk accepted this revision.Apr 27 2017, 7:11 AM
kfunk added a subscriber: kfunk.

Well, can't see anything wrong with this. +1.

This revision is now accepted and ready to land.Apr 27 2017, 7:11 AM
This revision was automatically updated to reflect the committed changes.