Differential D5587

Improvements
ClosedPublic
Actions

Authored by apol on Apr 25 2017, 6:03 PM.

Details

Reviewers
leinir
Group Reviewers
Frameworks
Commits
R304:ceecc1c47568: Improvements
Summary

Make sure we don't leak XmlLoader instances
Only rewrite the cache if it changed

Diff Detail

Repository
R304 KNewStuff
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.Apr 25 2017, 6:03 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 25 2017, 6:03 PM
leinir accepted this revision.Apr 26 2017, 8:30 AM

Looks good to me :)

This revision is now accepted and ready to land.Apr 26 2017, 8:30 AM
Closed by commit R304:ceecc1c47568: Improvements (authored by apol). · Explain WhyApr 26 2017, 1:49 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/core/cache.cpp (10 lines)
Msrc/core/xmlloader.cpp (1 line)

Diff 13832

View Options

src/core/cache.cpp

Loading...
View Options

src/core/xmlloader.cpp

Loading...