Differential D5574

Don't set ItemHasContents in DropArea
ClosedPublic
Actions

Authored by davidedmundson on Apr 25 2017, 12:12 AM.

Details

Reviewers
aacid
Group Reviewers
Plasma
Commits
R296:dec0d3d1c4f5: Don't set ItemHasContents in DropArea
Summary

ItemHasContents means we get included in generating the QSG node
treeview when we render.

This item doesn't have any contents. It's like a MouseArea.

::setEnabled() doesn't need updating as it was already missing.

Diff Detail

Repository
R296 KDeclarative
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptApr 25 2017, 12:12 AM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript
aacid accepted this revision.Apr 25 2017, 6:24 AM
This revision is now accepted and ready to land.Apr 25 2017, 6:24 AM
Closed by commit R296:dec0d3d1c4f5: Don't set ItemHasContents in DropArea (authored by davidedmundson). · Explain WhyApr 27 2017, 3:04 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 13882

View Options

src/qmlcontrols/draganddrop/DeclarativeDropArea.cpp

Loading...