fix basename handling of po files
ClosedPublic
Actions

Authored by sitter on Apr 24 2017, 7:58 AM.

Details

Reviewers

apol
ilic

Commits

R249:7bce4e812836: fix basename handling of po files

Summary

get_filename_component(... ... NAME_WE) gets the name without the *longest*
extension. in case of 'org.kde.plasma.kittens.po' that would leave us
with 'org' as name. Use a regular expression to grab the basename without
the short extension (e.g. 'org.kde.plasma.kittens') to prevent broken file
names.

add a test to assert that this works in the future

BUG: 379116

Diff Detail

Repository

R249 KI18n

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

sitter created this revision.Apr 24 2017, 7:58 AM

Restricted Application added a project: Frameworks. · View Herald TranscriptApr 24 2017, 7:58 AM

Restricted Application added a subscriber: Frameworks. · View Herald Transcript

Lgtm, thanks for the test!

cmake/build-pofiles.cmake
35 ↗	(On Diff #13728)	You don't need the second set of ()

This revision is now accepted and ready to land.Apr 24 2017, 4:19 PM

Closed by commit R249:7bce4e812836: fix basename handling of po files (authored by sitter). · Explain WhyApr 25 2017, 8:30 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		autotests/CMakeLists.txt (13 lines)
A	M	autotests/ki18n_install/CMakeLists.txt (6 lines)
A	M	autotests/ki18n_install/po/de/plasma_applet_org.kde.plasma.katesessions.po (20 lines)
A	M	autotests/ki18n_install/test.cmake (5 lines)
M		cmake/build-pofiles.cmake (7 lines)