Shorter command line. Please follow the guidelines for git commits. First line no more than 55/60 characters, followed by a blank line and the rest of the commit message (with more or less 78/80 character limit).

Also, do you have commit access?

Thanks for your review!
This is my first try with arcanist. Clearly not 100% success on the first try, it mangled my intended commit message.

Is there a link to the 'official' git commit guidelines? I.e. are there any more that I wasn't previously (made) aware of?

Should I simply re-run arc diff on an amended git commit? How do I get the amended review request to link/fold into this one?

I do have commit access.

In D5543#104009, @ouwerkerk wrote:

Thanks for your review!
This is my first try with arcanist. Clearly not 100% success on the first try, it mangled my intended commit message.

Is there a link to the 'official' git commit guidelines? I.e. are there any more that I wasn't previously (made) aware of?

Not really official, but most tools (starting with git log) works better if you follow that guidelines (short title+blank line+rest). See for example:

https://git-scm.com/book/en/v2/Distributed-Git-Contributing-to-a-Project

Should I simply re-run arc diff on an amended git commit? How do I get the amended review request to link/fold into this one?

In order to amend the content of a review, amend the local commit and re-run arc diff, but this does not change the commit message. You can update the commit message from the Phabricator UI.

I do have commit access.

Oki.

In order to amend the content of a review, amend the local commit and re-run arc diff, but this does not change the commit message.

Huh? Surely that is what git commit --amend allows you to do? What am I missing here?

In D5543#104011, @ouwerkerk wrote:

In order to amend the content of a review, amend the local commit and re-run arc diff, but this does not change the commit message.

Huh? Surely that is what git commit --amend allows you to do? What am I missing here?

git commit --amend changes the commit message. If you run arc diff, however, the new content of the commit is pushed to Phabricator (and the review is updated) but not the new commit message. You need to update the commit message from Phabricator.

and the title too.

The title in phabricator will be the first line of the git commit message.

Edited the various fields using the Phabricator UI instead, please let me know if this is more like what you were looking for instead.

Thanks! If you have committed this on top of the original branch (probably master, which is still the official branch), arc land should be enough to commit it.

But before doing it: are you sure that history.immutable is needed? I think that we forbid force-push on git.kde.org.

In D5543#104029, @ltoscano wrote:

Thanks! If you have committed this on top of the original branch (probably master, which is still the official branch), arc land should be enough to commit it.

No I branched off of frameworks.

In D5543#104029, @ltoscano wrote:

But before doing it: are you sure that history.immutable is needed? I think that we forbid force-push on git.kde.org.

From the section on history mutability in the docs:

arc diff will amend the commit message in HEAD after creating a revision.
arc land will default to the --squash strategy
arc amend will amend the commit message in HEAD with information from the corresponding or specified Differential revision.

Those 3 seem like potential for inadvertent adulterations of an otherwise 'clean' git history. Maybe I simply don't fully grasp arcanist/phabricator here?

It looks related to your local history, not the remote one, and the way it is pushed remotely. If you push one change at a time (one commit==one review) the default value is fine

So do you want me to restore the default, i.e remove the "history.immutability" option?

Unless someone else thinks differently, yes, I would say to not specify the value of history.immutable at least for now. We can discuss it at a higher level on KDE development mailing list, in case.