Guard against calling
ClosedPublic

Authored by davidedmundson on Apr 21 2017, 2:43 PM.

Details

Summary

It's possible to create a StylePlugin without calling ::create()
This can happen if we load the library and unload it without actually
loading the style.
drkonqi seems to do this..because drkonqi does weird things.

This ends up with us trying to unregister a callback that wasn't
registered which causes a crash in Qt.

Diff Detail

Repository
R626 QtCurve
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.

asdf

yuyichao accepted this revision.Apr 21 2017, 2:54 PM

Looks correct.

This revision is now accepted and ready to land.Apr 21 2017, 2:54 PM
rjvbb accepted this revision.Apr 25 2017, 12:15 PM

LGTM too.
Tested in conjunction with Debian's patches (rebased) to prevent the DBus-related crash on exit.

This revision was automatically updated to reflect the committed changes.