The disconnect was broken since it was added:
disconnect( this, SLOT(validateData()) );
(added in 9f46f693e743ad84032c7e820c61f2e45fc630e2)
which will call
QObject::disconnect(const QObject *receiver, const char *method) "Disconnects all signals in this object from receiver's method."
and thus not do what has been intended, to disconnect from the signal
of the previous importWidget.
The port to new signal/slot syntax did not improve the wrong logic
even if the very disconnect call was discussed for other reasons
in the review :)
(see commit f626743803ab900038890b04b5613b871d2c7ee1 and
As it seems needed to track the current import widget, to know whose
signal to disconnect from, the new member m_currentImportWidget
can be also used to drop code for dynamic lookup of that widget
in some the property access methods of ProjectVcsPage.
(will be a separate commit)
The broken disconnect did not result in a real bug from what I saw,
but still added noise in the debug log, so one reason to fix it.