Appwizard: fix broken disconnect in ProjectVcsPage

Authored by kossebau on Jan 27 2017, 3:22 PM.

Description

Appwizard: fix broken disconnect in ProjectVcsPage

Summary:
The disconnect was broken since it was added:

disconnect( this, SLOT(validateData()) );

(added in 9f46f693e743ad84032c7e820c61f2e45fc630e2)
which will call

QObject::disconnect(const QObject *receiver, const char *method)
"Disconnects all signals in this object from receiver's method."

and thus not do what has been intended, to disconnect from the signal
of the previous importWidget.
The port to new signal/slot syntax did not improve the wrong logic
even if the very disconnect call was discussed for other reasons
in the review :)
(see commit f626743803ab900038890b04b5613b871d2c7ee1 and
https://git.reviewboard.kde.org/r/121045)

The broken disconnect did not result in a real bug from what I saw,
but still added noise in the console log. No longer.

Reviewers: KDevelop, kfunk

Reviewed By: KDevelop, kfunk

Subscribers: kdevelop-devel

Differential Revision: https://phabricator.kde.org/D5536

Details

Committed
kossebauApr 27 2017, 12:30 PM
Reviewer
KDevelop
Differential Revision
D5536: Appwizard: fix broken disconnect in ProjectVcsPage
Parents
R33:2763fe3d3de8: Stop unused & broken exposure of Project object on D-Bus
Branches
Unknown
Tags
Unknown