Differential D5423

Guard against Applet not loading AppletInterface
ClosedPublic
Actions

Authored by davidedmundson on Apr 13 2017, 9:49 AM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R242:1387b5efe31e: Guard against Applet not loading AppletInterface
Summary

This can happen if an applet has invalid metadata, it doesn't have a
script engine set (X-Plasma-API) so it won't load the DeclarativeAppletScripts
Having invalid metadata could come from the applet, or from the fallback applet
created in Containment::Private::createApplet.

We guard against it in appletAdded but not in appletRemoved, which is
inconsistent. We also apparently must have guards elsewhere otherwise
we'd see the crash more.

BUG: 377050

Test Plan

Had corrupt applet, used to crash, now doesn't

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Apr 13 2017, 9:49 AM
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptApr 13 2017, 9:49 AM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript
mart accepted this revision.Apr 13 2017, 10:32 AM
This revision is now accepted and ready to land.Apr 13 2017, 10:32 AM
Closed by commit R242:1387b5efe31e: Guard against Applet not loading AppletInterface (authored by davidedmundson). · Explain WhyApr 13 2017, 11:01 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 13381

View Options

src/scriptengines/qml/plasmoid/containmentinterface.cpp

Loading...