Adding an option to show popular documents/apps for Kicker and Dash
ClosedPublic

Authored by ivan on Apr 9 2017, 8:36 PM.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ivan created this revision.Apr 9 2017, 8:36 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 9 2017, 8:36 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart edited edge metadata.Apr 10 2017, 10:46 AM

two small feedback pieces:

  1. not sure about the term "popular" as it would suggest most used by many people, while this is just about one user, would "most used" be better?
  2. let's try to make this default?
hein edited edge metadata.Apr 10 2017, 11:52 AM

Agreeing with Marco re "Most used", also because I can see "Popular" being an i18n challenge. In other languages the word that most closely maps to Popular might have an even more different sentiment from actually-most-used.

I'm kind of confused by the settings UI. Show ... first? As opposed to what? The bottom?

ivan added a comment.Apr 12 2017, 7:30 PM

"most used" is not what it does - it is a combination of most frequently and most recently used.

As for 'first', you are right. The source of the word was the possibility to show an infinite list.

ivan updated this revision to Diff 13509.Apr 16 2017, 8:29 AM

The combo box now has:

Recently used
Often used

Checkboxes are "recent"/"often used"

And the same for the text in the menu

ivan added a comment.Apr 16 2017, 8:30 AM

p.s. As for the default behaviour, I would not make it the default just yet. We need to test whether some things regarding scoring should be changed.

mart added a comment.Apr 16 2017, 5:27 PM

ok, so let's go with this.

hein accepted this revision.Apr 18 2017, 9:16 AM
This revision is now accepted and ready to land.Apr 18 2017, 9:16 AM
This revision was automatically updated to reflect the committed changes.