Qt.locale().standaloneMonthName() is used from QML side in MonthView,
so using the same code on C++ part again makes the month name in DaysView
have the same language.
This reverts commit 6f3fed77d59227a9b3ec85d343ffb2443086f7fa.
Details
Details
I use Czech for numbers, time, currency, units and English for everything
else. Now the calendar applet have all dates correctly in Czech.
Diff Detail
Diff Detail
- Repository
- R242 Plasma Framework (Library)
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage
Comment Actions
I disagree with this because we currently don't have any
easy and/or sensible way to change date formats and so
we simply suggest using different locales for the different
formats. However, if your UI language is all Spanish and
you want to use the US date formatting, the month name
labels would suddenly be in English while they should
remain Spanish (and this is what the code you're removing
does).
This should probably be fixed in the QML side to use the
same approach so that all month and day names are using
the same language, which should follow LANG, not LC_DATE.
Comment Actions
However, if your UI language is all Spanish and you want to use the US date formatting, the month name labels would suddenly be in English while they should remain Spanish (and this is what the code you're removing does).
Well, that's probably what you would want, but it's definitely not what you actually get in the current state. The whole calendar applet is in Czech for me (my UI language is English) - month and day names, only this one label is in English because it uses the string from C++ part (that was fixed).
Alright, I'll work on the QML fix instead.