Modernize: Use override where possible
AbandonedPublic
Actions

Authored by kfunk on Apr 4 2017, 6:12 PM.

Details

Reviewers

mardelle
alcinos

Summary

Note: The 'override' on dtor declarations require at least MSVC2015 on
Windows (if that's a concern)

Diff Detail

Repository

R158 Kdenlive

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

kfunk created this revision.Apr 4 2017, 6:12 PM

kfunk added reviewers: mardelle, alcinos.Apr 4 2017, 6:25 PM

I'm fine with this diff. However, please note that the development is currently taking place on branch "refactoring_timeline", so you may want to base your PRs on that. There is a unit-test suit on that one.
Also, I'm guessing that this PR is done by automatic tools. If you do something manually, you can safely ignore code in the following directories since they will be deleted soon:

timeline/
effectstack/
effectslist/

Ping me when you've merged this branch into master, then I'll re-run clang-tidy on this one.

kfunk abandoned this revision.Jul 31 2017, 9:57 AM

Large Diff

This large diff affects 123 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

			Path	Packages
M			renderer/renderjob.h (2 lines)
M			src/bin/abstractprojectitem.h (2 lines)
M			src/bin/bin.h (2 lines)
M			src/bin/generators/generators.h (2 lines)
M			src/bin/projectclip.h (2 lines)
M			src/bin/projectfolder.h (2 lines)
M			src/bin/projectfolderup.h (2 lines)
M			src/bin/projectitemmodel.h (2 lines)
M			src/bin/projectsubclip.h (2 lines)
M			src/capture/managecapturesdialog.h (2 lines)
M			src/capture/mltdevicecapture.h (2 lines)
M			src/core.h (2 lines)
M			src/dialogs/encodingprofilesdialog.h (2 lines)
M			src/dialogs/kdenlivesettingsdialog.h (2 lines)
M			src/dialogs/renderwidget.h (2 lines)
M			src/doc/documentchecker.h (2 lines)
M			src/doc/kdenlivedoc.h (2 lines)
M			src/dvdwizard/dvdwizard.h (2 lines)
M			src/dvdwizard/dvdwizardchapters.h (2 lines)
M			src/dvdwizard/dvdwizardmenu.h (2 lines)
M			src/dvdwizard/dvdwizardvob.h (2 lines)
M			src/effectslist/effectslistwidget.h (2 lines)
M			src/effectstack/collapsibleeffect.h (2 lines)
M			src/effectstack/collapsiblegroup.h (2 lines)
M			src/effectstack/dragvalue.h (2 lines)
M			src/effectstack/effectstackedit.h (2 lines)
M			src/effectstack/effectstackview2.h (2 lines)
M			src/effectstack/parametercontainer.h (2 lines)
M			src/effectstack/widgets/abstractparamwidget.h (2 lines)
M			src/effectstack/widgets/animationwidget.h (2 lines)
M			src/effectstack/widgets/boolparamwidget.h (2 lines)
M			src/effectstack/widgets/colorpickerwidget.h (2 lines)
M			src/effectstack/widgets/cornerswidget.h (2 lines)
M			src/effectstack/widgets/curves/abstractcurvewidget.h (10 lines)
M			src/effectstack/widgets/curves/bezier/beziersplineeditor.h (2 lines)
M			src/effectstack/widgets/curves/cubic/kis_curve_widget.h (2 lines)
M			src/effectstack/widgets/curves/curveparamwidget.h (4 lines)
M			src/effectstack/widgets/doubleparameterwidget.h (2 lines)
M			src/effectstack/widgets/draggablelabel.h (6 lines)
M			src/effectstack/widgets/geometrywidget.h (2 lines)
M			src/effectstack/widgets/keyframeedit.h (2 lines)
M			src/effectstack/widgets/keyframeimport.h (2 lines)
M			src/effectstack/widgets/listparamwidget.h (2 lines)
M			src/effectstack/widgets/positionwidget.h (2 lines)
M			src/effectstack/widgets/selectivecolor.h (2 lines)
M			src/jogshuttle/jogaction.h (2 lines)
M			src/jogshuttle/jogshuttle.h (4 lines)
M			src/lib/audio/audioCorrelation.h (2 lines)
M			src/lib/audio/audioEnvelope.h (2 lines)
M			src/mainwindow.h (2 lines)
M			src/mltcontroller/bincontroller.h (2 lines)
M			src/mltcontroller/clipcontroller.h (2 lines)
M			src/mltcontroller/clippropertiescontroller.h (2 lines)
M			src/mltcontroller/producerqueue.h (2 lines)
M			src/monitor/abstractmonitor.h (4 lines)
M			src/monitor/glwidget.h (6 lines)
M			src/monitor/monitor.h (2 lines)
M			src/monitor/recmanager.h (2 lines)
M			src/monitor/recmonitor.h (2 lines)
M			src/monitor/scopes/audiographspectrum.h (2 lines)
M			src/monitor/scopes/monitoraudiolevel.h (2 lines)
M			src/monitor/scopes/scopewidget.h (2 lines)
M			src/onmonitoritems/rotoscoping/rotowidget.h (2 lines)
M			src/profiles/tree/profiletreemodel.hpp (2 lines)
M			src/project/clipmanager.h (2 lines)
M			src/project/clipstabilize.h (2 lines)
M			src/project/cliptranscode.h (2 lines)
M			src/project/dialogs/archivewidget.h (2 lines)
M			src/project/dialogs/backupwidget.h (2 lines)
M			src/project/dialogs/noteswidget.h (2 lines)
M			src/project/dialogs/profilewidget.h (2 lines)
M			src/project/dialogs/slideshowclip.h (2 lines)
M			src/project/invaliddialog.h (2 lines)
M			src/project/jobs/abstractclipjob.h (2 lines)
M			src/project/jobs/cutclipjob.h (2 lines)
M			src/project/jobs/jobmanager.h (2 lines)
M			src/project/jobs/meltjob.h (2 lines)
M			src/project/jobs/proxyclipjob.h (2 lines)
M			src/project/notesplugin.h (2 lines)
M			src/project/projectmanager.h (2 lines)
M			src/qt-oauth-lib/logindialog.h (2 lines)
M			src/renderer.h (2 lines)
M			src/scopes/abstractscopewidget.h (2 lines)
M			src/scopes/audioscopes/abstractaudioscopewidget.h (2 lines)
M			src/scopes/audioscopes/audiosignal.h (2 lines)
M			src/scopes/audioscopes/audiospectrum.h (2 lines)
M			src/scopes/audioscopes/spectrogram.h (2 lines)
M			src/scopes/colorscopes/abstractgfxscopewidget.h (2 lines)
M			src/scopes/colorscopes/colorplaneexport.h (2 lines)
M			src/scopes/colorscopes/histogram.h (2 lines)
M			src/scopes/colorscopes/rgbparade.h (2 lines)
M			src/scopes/colorscopes/vectorscope.h (2 lines)
M			src/scopes/colorscopes/waveform.h (2 lines)
M			src/scopes/colorscopes/waveformgenerator.h (2 lines)
M			src/simplekeyframes/simplekeyframewidget.h (2 lines)
M			src/statusbarmessagelabel.h (4 lines)
M			src/stopmotion/stopmotion.h (4 lines)
M			src/timeline/abstractclipitem.h (2 lines)
M			src/timeline/clip.h (2 lines)
M			src/timeline/clipdurationdialog.h (2 lines)
M			src/timeline/clipitem.h (2 lines)
M			src/timeline/customtrackscene.h (2 lines)
M			src/timeline/customtrackview.h (2 lines)
M			src/timeline/effectmanager.h (2 lines)
M			src/timeline/headertrack.h (2 lines)
M			src/timeline/keyframeview.h (2 lines)
M			src/timeline/managers/previewmanager.h (2 lines)
M			src/timeline/markerdialog.h (2 lines)
M			src/timeline/timeline.h (2 lines)
M			src/timeline/track.h (2 lines)
M			src/timeline/transition.h (2 lines)
M			src/titler/KoSliderCombo.h (2 lines)
M			src/titler/titlewidget.h (2 lines)
M			src/titler/unicodedialog.h (4 lines)
M			src/utils/abstractservice.h (2 lines)
M			src/utils/archiveorg.h (2 lines)
M			src/utils/flowlayout.h (2 lines)
M			src/utils/freesound.h (2 lines)
M			src/utils/openclipart.h (2 lines)
M			src/utils/progressbutton.h (2 lines)
M			src/utils/resourcewidget.h (2 lines)
M			src/utils/thememanager.h (2 lines)
M			thumbnailer/mltpreview.h (2 lines)

Commit	Tree	Parents	Author	Summary	Date
00e92f90b4cf	c6ac24c35da8	8ec829f1b6de	Kevin Funk	Modernize: Use override where possible (Show More…)	Apr 4 2017, 6:11 PM

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	13095	8ec829f		Apr 4 2017, 6:12 PM	★	★

Modernize: Use override where possibleAbandonedPublicActions

Details

Diff Detail

Large Diff

Revision ContentsChangeset List

Diff 13095

renderer/renderjob.h

src/bin/abstractprojectitem.h

src/bin/bin.h

src/bin/generators/generators.h

src/bin/projectclip.h

src/bin/projectfolder.h

src/bin/projectfolderup.h

src/bin/projectitemmodel.h

src/bin/projectsubclip.h

src/capture/managecapturesdialog.h

src/capture/mltdevicecapture.h

src/core.h

src/dialogs/encodingprofilesdialog.h

src/dialogs/kdenlivesettingsdialog.h

src/dialogs/renderwidget.h

src/doc/documentchecker.h

src/doc/kdenlivedoc.h

src/dvdwizard/dvdwizard.h

src/dvdwizard/dvdwizardchapters.h

src/dvdwizard/dvdwizardmenu.h

src/dvdwizard/dvdwizardvob.h

src/effectslist/effectslistwidget.h

src/effectstack/collapsibleeffect.h

src/effectstack/collapsiblegroup.h

src/effectstack/dragvalue.h

src/effectstack/effectstackedit.h

src/effectstack/effectstackview2.h

src/effectstack/parametercontainer.h

src/effectstack/widgets/abstractparamwidget.h

src/effectstack/widgets/animationwidget.h

src/effectstack/widgets/boolparamwidget.h

src/effectstack/widgets/colorpickerwidget.h

src/effectstack/widgets/cornerswidget.h

src/effectstack/widgets/curves/abstractcurvewidget.h

src/effectstack/widgets/curves/bezier/beziersplineeditor.h

src/effectstack/widgets/curves/cubic/kis_curve_widget.h

src/effectstack/widgets/curves/curveparamwidget.h

src/effectstack/widgets/doubleparameterwidget.h

src/effectstack/widgets/draggablelabel.h

src/effectstack/widgets/geometrywidget.h

src/effectstack/widgets/keyframeedit.h

src/effectstack/widgets/keyframeimport.h

src/effectstack/widgets/listparamwidget.h

src/effectstack/widgets/positionwidget.h

src/effectstack/widgets/selectivecolor.h

src/jogshuttle/jogaction.h

src/jogshuttle/jogshuttle.h

src/lib/audio/audioCorrelation.h

src/lib/audio/audioEnvelope.h

src/mainwindow.h

src/mltcontroller/bincontroller.h

src/mltcontroller/clipcontroller.h

src/mltcontroller/clippropertiescontroller.h

src/mltcontroller/producerqueue.h

src/monitor/abstractmonitor.h

src/monitor/glwidget.h

src/monitor/monitor.h

src/monitor/recmanager.h

src/monitor/recmonitor.h

src/monitor/scopes/audiographspectrum.h

src/monitor/scopes/monitoraudiolevel.h

src/monitor/scopes/scopewidget.h

src/onmonitoritems/rotoscoping/rotowidget.h

src/profiles/tree/profiletreemodel.hpp

src/project/clipmanager.h

src/project/clipstabilize.h

src/project/cliptranscode.h

src/project/dialogs/archivewidget.h

src/project/dialogs/backupwidget.h

src/project/dialogs/noteswidget.h

src/project/dialogs/profilewidget.h

src/project/dialogs/slideshowclip.h

src/project/invaliddialog.h

src/project/jobs/abstractclipjob.h

Modernize: Use override where possible
AbandonedPublic
Actions

Revision Contents
Changeset List