Differential D5255

[Task Manager] Keep entry highlighted when context menu or group dialog is open
ClosedPublic
Actions

Authored by broulik on Mar 30 2017, 11:57 AM.

Details

Reviewers
hein
Group Reviewers
VDG
Plasma
Summary

This makes it easier to see what item the menu or popup is for.
In fact, the item should have stayed highlighted when the context menu is open but this was broken.
Also, for consistency, use the hover effect also for the group dialog (it used to be the "active" task).

Test Plan

Context menu open but mouse cursor outside of task item


Group dialog

Diff Detail

Repository
R119 Plasma Desktop
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Mar 30 2017, 11:57 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 30 2017, 11:57 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
romangg added a subscriber: romangg.Mar 30 2017, 12:36 PM

Good idea! Maybe also when task tooltip open?

hein accepted this revision.Mar 30 2017, 5:44 PM

This must be a recent regression - it worked before.

-1 on the tooltip thing, too much noise.

This revision is now accepted and ready to land.Mar 30 2017, 5:44 PM
broulik added a comment.Mar 30 2017, 5:45 PM

This must be a recent regression - it worked before.

I think that was even me adding the Places stuff, I re-arranged some context menu stuff and accidentally caused the property QtObject contextMenu to become unused.

broulik closed this revision.Mar 31 2017, 9:27 AM

Submitted as D5260 which was merged to master and adjusted for changes (essentially becoming this patch)

Revision Contents
Changeset List

Diff 13002

View Options

applets/taskmanager/package/contents/ui/Task.qml

Loading...