Differential D5247

[ModelContextMenu] Silence warnings
ClosedPublic
Actions

Authored by broulik on Mar 29 2017, 4:41 PM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R242:edb05ef98983: [ModelContextMenu] Silence warnings
Summary

When using a regular JavaScript Array as model and omitting certain roles (e.g. not having a "text" for a separator) it would throw a warning.

Test Plan

Color picker no longer throws warnings in its menu (I use sections and separators here).
Widget explorer filter and download widgets buttons still work

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Mar 29 2017, 4:41 PM
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptMar 29 2017, 4:41 PM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript
mart accepted this revision.Mar 30 2017, 1:02 PM
This revision is now accepted and ready to land.Mar 30 2017, 1:02 PM
Closed by commit R242:edb05ef98983: [ModelContextMenu] Silence warnings (authored by broulik). · Explain WhyMar 30 2017, 1:04 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 13004

View Options

src/declarativeimports/plasmacomponents/qml/ModelContextMenu.qml

Loading...