Differential D5226

[Folder View] Use toDisplayString which strips passwords
ClosedPublic
Actions

Authored by broulik on Mar 28 2017, 4:05 PM.

Details

Reviewers
hein
Group Reviewers
Plasma
Commits
R119:b9eedbe78c79: [Folder View] Use toDisplayString which strips passwords
Summary

Otherwise we might be leaking sensitive information.

Test Plan

I want to get this in before D5223 so I can rebase it ontop of this and save me a merge-dance.

Configured URL as sftp://foo:bar@example.com and neither the default label type nor the "full path" would reveal the password.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Mar 28 2017, 4:05 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 28 2017, 4:05 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
hein accepted this revision.Mar 28 2017, 4:09 PM
This revision is now accepted and ready to land.Mar 28 2017, 4:09 PM
Closed by commit R119:b9eedbe78c79: [Folder View] Use toDisplayString which strips passwords (authored by broulik). · Explain WhyMar 28 2017, 4:15 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 12927

View Options

containments/desktop/plugins/folder/labelgenerator.cpp

Loading...