Differential D5215

[ModelContextMenu] Use Instantiator insteadof Repeater-and-reparent-hack
ClosedPublic
Actions

Authored by broulik on Mar 28 2017, 12:14 PM.

Details

Reviewers
apol
Group Reviewers
Plasma
Commits
R242:8d42e0072f46: [ModelContextMenu] Use Instantiator instead of Repeater-and-reparent-hack
Test Plan

Clicking the "add widgets" button multiple times in widget explorer no longer crashes/confuses it because the Repeater destroys its items when model is assigned a new JS Array as is done in widget explorer.

Also the category selection in widget explorer still works.

There's no addMenuItemAt method and the old code also didn't care about the order of items so it shouldn't be worse than before.

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Mar 28 2017, 12:14 PM
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptMar 28 2017, 12:14 PM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript
apol accepted this revision.Mar 28 2017, 5:36 PM
This revision is now accepted and ready to land.Mar 28 2017, 5:36 PM
Closed by commit R242:8d42e0072f46: [ModelContextMenu] Use Instantiator instead of Repeater-and-reparent-hack (authored by broulik). · Explain WhyMar 29 2017, 10:13 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 12950

View Options

src/declarativeimports/plasmacomponents/qml/ModelContextMenu.qml

Loading...