Differential D5204

[Folder View] Show pin icon only if really in a popup
ClosedPublic
Actions

Authored by broulik on Mar 27 2017, 6:05 PM.

Details

Reviewers
hein
Group Reviewers
VDG
Plasma
Commits
R119:fc94d0f2fd3e: [Folder View] Show pin icon only if really in a popup
Summary

When placed in a wide panel, Folder View would reveal its contents but the pin icon was still there

Test Plan

Pin icon no longer shows up when expanded in a panel but still shows when placed in narrow panel with popup. Even updates at runtime when I resize the panel

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Mar 27 2017, 6:05 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 27 2017, 6:05 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
hein accepted this revision.Mar 28 2017, 8:42 AM
hein added a subscriber: hein.

Good catch.

This revision is now accepted and ready to land.Mar 28 2017, 8:42 AM
Closed by commit R119:fc94d0f2fd3e: [Folder View] Show pin icon only if really in a popup (authored by broulik). · Explain WhyMar 28 2017, 9:00 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 12899

View Options

containments/desktop/package/contents/ui/FolderViewLayer.qml

Loading...