Differential D5202

[Default Tooltip] Fix icon size
ClosedPublic
Actions

Authored by broulik on Mar 27 2017, 5:56 PM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R242:7487e208b696: [Default Tooltip] Fix icon size
Summary

We overwrite implicit size based on the icon loaded nowadays which breaks this.
Also, while at it, added an explicit "valid" check for the icon.

Test Plan

No longer get icon sizes all over the place in systray.

While this is a behavior change, Image for instance always had its implicit size based on the loaded image and even has a read-only size, so I think this behavior is somewhat expectable.

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Mar 27 2017, 5:56 PM
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptMar 27 2017, 5:56 PM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript
broulik edited the summary of this revision. (Show Details)Mar 27 2017, 5:56 PM
mart accepted this revision.Mar 28 2017, 9:04 AM
This revision is now accepted and ready to land.Mar 28 2017, 9:04 AM
Closed by commit R242:7487e208b696: [Default Tooltip] Fix icon size (authored by broulik). · Explain WhyMar 28 2017, 9:06 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 12900

View Options

src/declarativeimports/core/private/DefaultToolTip.qml

Loading...