prevent signals in glib2 be defined by QT
ClosedPublic

Authored by RobberPhex on Mar 26 2017, 4:32 PM.

Details

Summary

Because signals in glib2 be defined by QT, cause Bug 378109 - signals in glib2 was defined by QT.

This solved this.

Test Plan

Use nm_conn.cpp,

before it cannot compiled, after patch, nm_conn.cpp can compiled.

Diff Detail

Repository
R282 NetworkManagerQt
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
RobberPhex created this revision.Mar 26 2017, 4:32 PM
dfaure accepted this revision.Mar 26 2017, 4:58 PM
dfaure added a subscriber: dfaure.

Ah, networkmanager-qt itself uses KDEFrameworkCompilerSettings so it gets -DQT_NO_SIGNALS_SLOTS_KEYWORDS, i.e. signals isn't defined.
But indeed this is an installed public header, so the fix is necessary for apps that don't use these settings.

This revision is now accepted and ready to land.Mar 26 2017, 4:58 PM
This revision was automatically updated to reflect the committed changes.