Differential D5184

Accept single line command options like we used to do
ClosedPublic
Actions

Authored by aacid on Mar 26 2017, 4:27 PM.

Details

Reviewers
dfaure
Commits
R226:5aa274d693e4: Merge remote-tracking branch 'origin/Applications/17.04'
R226:b9d97bd051bd: Accept single line command options like we used to do
Summary

Including this own repository

./client/kfmclient.cpp:258:

that uses a single dash instead of two

Diff Detail

Repository
R226 Konqueror
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
aacid created this revision.Mar 26 2017, 4:27 PM
dfaure accepted this revision.Mar 26 2017, 4:49 PM

I'd rather we fix kfmclient.cpp to add the missing dash, but OK, if we care for command-line compatibility with KDE4 era then we should use ParseAsLongOptions.... everywhere...

This revision is now accepted and ready to land.Mar 26 2017, 4:49 PM
aacid added a comment.Mar 26 2017, 6:11 PM
In D5184#97693, @dfaure wrote:

I'd rather we fix kfmclient.cpp to add the missing dash, but OK, if we care for command-line compatibility with KDE4 era then we should use ParseAsLongOptions.... everywhere...

Yes, we should care, and more over in "famous" stuff that is probably called from scripts and stuff.

Closed by commit R226:b9d97bd051bd: Accept single line command options like we used to do (authored by aacid). · Explain WhyMar 26 2017, 6:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/konqmain.cpp (1 line)

Diff 12836

View Options

src/konqmain.cpp

Loading...