Differential D5165

Avoiding root mode
ClosedPublic
Actions

Authored by abika on Mar 24 2017, 3:02 PM.

Details

Reviewers
martinkostolny
Group Reviewers
Krusader
Commits
R167:d51417cec648: Merge branch 'my-avoid_root_mode'
Summary

See the discussion for D4725.

Removed Krusader root desktop icon
Do not promote insecure behaviour.

Added warning dialog before running Krusader in root mode

Diff Detail

Repository
R167 Krusader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
abika created this revision.Mar 24 2017, 3:02 PM
abika added a comment.Mar 31 2017, 7:57 PM

Can someone please give an opinion on this?

martinkostolny accepted this revision.Mar 31 2017, 11:26 PM
martinkostolny added a subscriber: martinkostolny.

Sorry, for the late response. Yes, this is good, I like it. Thanks!

This revision is now accepted and ready to land.Mar 31 2017, 11:26 PM
Closed by commit R167:d51417cec648: Merge branch 'my-avoid_root_mode' (authored by Alexander Bikadorov <alex.bikadorov@kdemail.net>). · Explain WhyApr 3 2017, 6:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 13074

View Options

krusader/CMakeLists.txt

Loading...
View Options

krusader/krslots.cpp

Loading...
View Options

krusader/org.kde.krusader.root-mode.desktop

Loading...