Differential D5141

Improve the reliability of AtCore::stop and AtCore::emergencyStop
ClosedPublic
Actions

Authored by rizzitello on Mar 22 2017, 10:13 PM.

Details

Reviewers
tcanabrava
laysrodrigues
patrickelectric
Commits
R232:186457055654: Emergency Stop should stop faster and not have any left over commands in the…
R232:f863dd66fce9: Do not set state to IDLE in atcore::Stop fix printthread to force it find EOF…
Summary

before we were having a problem where the state could change before the print thread had a chance to react to the state.

Diff Detail

Repository
R232 AtCore
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rizzitello created this revision.Mar 22 2017, 10:13 PM
rizzitello edited the summary of this revision. (Show Details)Mar 22 2017, 10:16 PM
rizzitello added reviewers: laysrodrigues, patrickelectric, tcanabrava.
rizzitello added a subscriber: Atelier: AtCore.
laysrodrigues accepted this revision.Mar 27 2017, 12:35 PM
This revision is now accepted and ready to land.Mar 27 2017, 12:35 PM
Closed by commit R232:f863dd66fce9: Do not set state to IDLE in atcore::Stop fix printthread to force it find EOF… (authored by rizzitello). · Explain WhyMar 27 2017, 8:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/atcore.cpp (1 line)
Msrc/printthread.cpp (3 lines)

Diff 12882

View Options

src/atcore.cpp

Loading...
View Options

src/printthread.cpp

Loading...