Differential D5134

Don't exit if $DISPLAY is not set
AbandonedPublic
Actions

Authored by aacid on Mar 22 2017, 4:46 PM.

Details

Reviewers
graesslin
Summary

The fact that kinit was build with X11 doesn't mean it will be using X11 at runtime

Diff Detail

Repository
R303 KInit
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
aacid created this revision.Mar 22 2017, 4:46 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 22 2017, 4:46 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
lukas added a subscriber: lukas.Mar 22 2017, 5:02 PM
graesslin requested changes to this revision.Mar 22 2017, 7:15 PM
graesslin added a subscriber: graesslin.

As I stumbled over that years ago: sorry I don't think that this is the proper solution. This is basically T4431 which is not yet implemented. What this change suggest is a rather hacky solution.

Kinit if built with X11 is still requiring the DISPLAY variable all over the place. The only solution is to run an X server, even if it is not the X platform As we do on Plasma/Wayland

This revision now requires changes to proceed.Mar 22 2017, 7:15 PM
aacid added a comment.Mar 23 2017, 8:55 AM

Kinit if built with X11 is still requiring the DISPLAY variable all over the place. The only solution is to run an X server, even if it is not the X platform As we do on Plasma/Wayland

I don't know what you mean by "only solution" because with this change things seem to work fine for me (and I'm not running an X server)

Reading the code the only thing that seems I am missing is startup notification.

aacid abandoned this revision.May 27 2017, 5:00 PM

Revision Contents
Changeset List

PathPackages
Msrc/kdeinit/kinit.cpp (4 lines)
Msrc/wrapper.cpp (4 lines)

Diff 12694

View Options

src/kdeinit/kinit.cpp

Loading...
View Options

src/wrapper.cpp

Loading...