Differential D5128

Set no stepper button for GTK3 scrollbars on gtk >=3.20
ClosedPublic
Actions

Authored by rikmills on Mar 22 2017, 11:08 AM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R98:6ac39e82ff06: Set no stepper button for GTK3 scrollbars on gtk >=3.20
Summary

This is a workaround to mitigate broken (huge wide) scrollbars in mozilla/Gecko based applications for GTK3 >= 3.20 in versions 52 onwards.

Saying that, I think it now brings those GTK3 scrollbars closer to the Breeze Qt scrollbars in latest releases.

Ref: https://bugs.kde.org/show_bug.cgi?id=377008 and https://bugzilla.mozilla.org/show_bug.cgi?id=1343802

The mozilla bug is now 'fixed' and landing in nightlies v55, but may continue to affect earlier releases if not brought forward upstream.

before:

after

Test Plan

I have tested this locally for myself, and staged a patched build for kubuntu here:

https://launchpad.net/~kubuntu-ppa/+archive/ubuntu/staging-plasma/+packages?field.name_filter=breeze-gtk&field.status_filter=published&field.series_filter=zesty

Tested in a few non-gecko GTK3 based apps to see the result:

e.g. in Nautilus

Maybe the bordering around the scrollbar trough could be better? Not sure, and my GTK/CSS fu is probably not up to much more than trial and error from here onwards.

Diff Detail

Repository
R98 Breeze for Gtk
Lint
Lint Skipped
Unit
Unit Tests Skipped
rikmills created this revision.Mar 22 2017, 11:08 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 22 2017, 11:08 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
rikmills added a comment.Mar 23 2017, 3:18 PM

I note that in recent Breeze, the native scrollbar are a fair amount thinner, so maybe a reduction in width here by 2 px may look/match better?

e.g.

elvisangelaccio added a subscriber: elvisangelaccio.EditedMar 28 2017, 8:59 PM

It seems the upstream firefox bug has been fixed, can you update the commit message?
Anyway +1 for removing the stepper buttons, currently there is an annoying difference between breeze and breeze-gtk3 scrollbars.

rikmills edited the summary of this revision. (Show Details)Mar 28 2017, 9:12 PM
In D5128#98591, @elvisangelaccio wrote:

It seems the upstream firefox bug has been fixed, can you update to commit message?
Anyway +1 for removing the stepper buttons, currently there is an annoying difference between breeze and breeze-gtk3 scrollbars.

Done, I think.

rikmills added a comment.Mar 30 2017, 9:13 AM

Checked appearance on 'fixed' Firefox 55 nightly. No apparent regressions with those upstream changes and this change as far as I can see.

davidedmundson accepted this revision.May 12 2017, 2:37 PM
davidedmundson added a subscriber: davidedmundson.

Plasma 5.10 branch too. Do you have commit access?

This revision is now accepted and ready to land.May 12 2017, 2:37 PM
Closed by commit R98:6ac39e82ff06: Set no stepper button for GTK3 scrollbars on gtk >=3.20 (authored by rikmills). · Explain WhyMay 12 2017, 4:25 PM
This revision was automatically updated to reflect the committed changes.
rikmills mentioned this in R98:6ac39e82ff06: Set no stepper button for GTK3 scrollbars on gtk >=3.20.

Revision Contents
Changeset List

Diff 12678

View Options

Breeze-dark-gtk/gtk-3.20/gtk.css

Loading...
View Options

Breeze-gtk/gtk-3.20/gtk.css

Loading...