I'm fairly sure '!=' is the intended meaning in the first two hunks.
No idea at all what the bit-hack-with-narrowing-conversions is meant to do, but nothing actually seems to use it (in any kdev*).
Details
Details
- Reviewers
kfunk - Group Reviewers
KDevelop - Commits
- R51:cbfbaf9125b0: Fix compile warnings with clang
Compiles, the tests pass. kdev-php hasn't obviously blown up.
Diff Detail
Diff Detail
- Repository
- R51 KDevelop: PG Qt
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
First time I see the code, but the changes look sound.
+1
(Also, what where they thinking!? !smth==0 >.<
Comment Actions
Generally: +1
Files in kdev-pg/AS* are thirdparty code, maybe we should rather try syncing the source files from upstream & check whether they've fixed the issue already?