Properly find zipconf.h
AbandonedPublic

Authored by elvisangelaccio on Mar 18 2017, 2:51 PM.

Details

Reviewers
rthomsen
Summary

libzip installs zipconf.h in $prefix/$libdir/libzip/include/. Some
systems (e.g. archlinux) symlinks this file under $prefix/$libdir/include
for compatibility reasons, but cmake fails on systems that do not (e.g.
flatpak). Since libzip supports pkg-config, we can just query pkg-config
which gives us the proper path we are looking for.

This breaks the Applications dependency freeze, but it's an important
fix so it should go in.

Test Plan

ark master flatpak now can build the new libzip plugin.

Diff Detail

Repository
R36 Ark
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Restricted Application added a project: Ark. · View Herald TranscriptMar 18 2017, 2:51 PM
Restricted Application added subscribers: Ark, kde-utils-devel. · View Herald Transcript

@rthomsen As alternative, we don't even need to look for zipconf.h, as pkg-config can tell us directly the version number of libzip...

@rthomsen As alternative, we don't even need to look for zipconf.h, as pkg-config can tell us directly the version number of libzip...

Actually it looks like the version detection doesn't work at all. Ark builds the libzip plugins even if I have libzip < 1.2 installed...

elvisangelaccio abandoned this revision.Mar 18 2017, 3:32 PM

@rthomsen As alternative, we don't even need to look for zipconf.h, as pkg-config can tell us directly the version number of libzip...

Actually it looks like the version detection doesn't work at all. Ark builds the libzip plugins even if I have libzip < 1.2 installed...

Superseded by D5101.