Add appropriate buttons to open a QFileDialog in which you could select either files or folders depending on the clicked button.
BUG: 365034
Add appropriate buttons to open a QFileDialog in which you could select either files or folders depending on the clicked button.
BUG: 365034
It compiles and works as it should.
Before
After
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
Fine with me. I'm not sure what the VDG would say about the UI design, but I cannot think of a better solution either, so I think this is OK.
libdialogpages/filespage.cpp | ||
---|---|---|
140 | Shouldn't this be an OR ( | ) instead? This even fails to build with gcc6: |
Not really relevant for the current functionality, but:
libdialogpages/filespage.cpp | ||
---|---|---|
189–193 | I think it would be more correct to hide the button if KFile::Directory is not specified, instead of if the mode is (KFile::File | KFile::ExistingOnly). I.e. something like: | |
199–203 | Same here |